fix: eventsource does not reconnect on network error #4247
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metcoder95
approved these changes
Jun 2, 2025
KhafraDev
reviewed
Jun 2, 2025
|
|
||
| eventSourceInstance.close() | ||
|
|
||
| assert.strictEqual(onerrorCalls.length, 3) |
There was a problem hiding this comment.
Yes, defaultReconnectTime is 3000. So 1. Is about after 50-100 ms, next is 3050-3100ms and the third is at 6050-6100ms. A fourth would be after 9050-9100 ms, but we just do 7000ms (or 8000?) and so we have only 3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be honest: I am pretty much confused, why we had this regression. In #2665 the setTimeout got replaced with the non promise one, and thus broke the reconnection logic. It seems like setTimeout from timers/promise without reference, still keeps the process running, but the unref`d normal setTimeout results in letting the process die, even though we are still in reconning state.
Also I dont understand anymore why I wrote the close logic into
processEventSourceEndOfBody.So take this PR with a grain of salt.