Skip to content

types(websocket): Import from stream/web #4038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 7, 2025

Conversation

Jiralite
Copy link
Contributor

@Jiralite Jiralite commented Feb 1, 2025

This relates to...

N/A

Rationale

ReadableStream and WritableStream were not imported in the typings. This pull request imports them from stream/web.

Changes

Features

N/A

Bug Fixes

Fixes TypeScript compilation error:

types/websocket.d.ts(167,15): error TS2304: Cannot find name 'ReadableStream'.
types/websocket.d.ts(168,15): error TS2304: Cannot find name 'WritableStream'.

https://github.com/discordjs/discord.js/actions/runs/13081715315/job/36506493876

Breaking Changes and Deprecations

N/A

Status

Copy link
Member

@metcoder95 metcoder95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add some test to it?

@Jiralite Jiralite force-pushed the types/websocket-import branch from c2f61cb to 003e3e5 Compare February 2, 2025 10:14
@Jiralite Jiralite changed the title types(websocket): import from stream/web types(websocket): Import from stream/web Feb 2, 2025
@Jiralite Jiralite requested a review from metcoder95 February 2, 2025 10:14
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Jiralite Jiralite force-pushed the types/websocket-import branch from 003e3e5 to ecd828e Compare February 7, 2025 21:41
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Jiralite Jiralite force-pushed the types/websocket-import branch from ecd828e to 1e05453 Compare April 5, 2025 10:40
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit d2be897 into nodejs:main Apr 7, 2025
25 of 31 checks passed
@Jiralite Jiralite deleted the types/websocket-import branch April 7, 2025 16:25
@github-actions github-actions bot mentioned this pull request Apr 10, 2025
@github-actions github-actions bot mentioned this pull request May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants