Skip to content

Conversation

hupfdule
Copy link

By default this is bound to key 'v' as in less.
It opens the current file in one of the following editors (tried in the given order):

  • $OVEDIT
  • Editor from config file
  • $LESSEDIT
  • $VISUAL
  • sensible-editor
  • EDITOR
  • vi

By default this is bound to key 'v' as in less.
It opens the current file in one of the following editors (tried in the given order):

 - $OVEDIT
 - Editor from config file
 - $LESSEDIT
 - $VISUAL
 - sensible-editor
 - EDITOR
 - vi
Comment on lines +718 to +721
//TODO: Reread the file
root.Doc.ReadFile(root.Doc.FileName)
root.viewSync()
root.Screen.Sync()
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are currently two issues here:

  1. Rereading the modified file doesn't work.
  2. "Some" keypresses in the opened editor are hijacked by ov (and therefore swallowed) and the last keypress in the opened editor will always be interpreted by ov (e.g. quitting vi via :wq will quit ov, since it interprets the q). We would actually need to suspend interpreting keypresses before opening the editor and resume it again afterwards. But I don't know how to do this with tcell/cbind.

Help with both problem is very appreciated.

@noborus
Copy link
Owner

noborus commented Oct 23, 2020

I'm sorry.
Launching the editor may not work well with the current changes.
I'm using tcell and I have a problem that I can't go back when I start another screen.

@noborus
Copy link
Owner

noborus commented Jan 28, 2022

Since tcell suspend works, I may implement it myself in the future.
This PR will be closed. Thank you very much.

@noborus noborus closed this Jan 28, 2022
@groutoutlook
Copy link

hi, @noborus, have you had enough time and interests to work on this feature? The implementation of it could look like this from moar.

I myself am not experienced with go so I hope this could be a little of help. Love your work with this pager.

@noborus
Copy link
Owner

noborus commented May 19, 2025

hi, @noborus, have you had enough time and interests to work on this feature? The implementation of it could look like this from moar.

I myself am not experienced with go so I hope this could be a little of help. Love your work with this pager.

Thank you for your comment.
I think I can implement it now.
I will create an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants