Fix Getpgrp support for cross-platform compatibility #806
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Rename suspend.go to suspend_unix.go for Unix-specific implementation - Rename suspend_windows.go to suspend_other.go for other platforms - Update go.mod dependencies Fixes #805
There was a problem hiding this comment.
Pull Request Overview
This PR aims to improve cross-platform compatibility by renaming platform-specific files, updating build tags, and switching to the appropriate API for process group retrieval on Unix systems.
- Renames suspend.go to suspend_unix.go and suspend_windows.go to suspend_other.go with updated build tags
- Replaces syscall.Getpgrp with unix.Getpgrp in the Unix implementation
- Updates go.mod dependencies to include the correct version of golang.org/x/sys
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| oviewer/suspend_unix.go | Updated build tags and API call to use golang.org/x/sys/unix for process group retrieval |
| oviewer/suspend_other.go | Renamed file with adjusted build tag and improved comment clarity |
| go.mod | Added and adjusted dependency on golang.org/x/sys |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #805