Enable passing stripped escape sequences to the editor #787
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When executing edit in plain mode, escape sequences are stripped before passing to the editor.
- Implemented logic to distinguish and set appropriate stdin (os.Stdin or /dev/tty) when launching the editor - Ensures correct behavior whether standard input is a terminal or a pipe
- Changed behavior to create and use a temporary file when editing in PlainMode - Ensures consistent editing experience for non-seekable and plain documents - Stopped checking the VISUAL environment variable; now only EDITOR is used
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When executing edit in plain mode, escape sequences are stripped before passing to the editor.