Improved movement in the document display area #698
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Move doc.width and doc.height definitions. - Replace validWidth with doc.width for consistency.
- Modified `oviewer/draw.go` to handle cases where the vertical header count exceeds the actual number of columns. - Updated tests in `oviewer/draw_test.go` to cover the new behavior. - Adjusted lateral movement logic in `oviewer/move_lateral.go` to support the change. - Changed `determineColumnStart` to return 0 when there are no columns.
Added a message display when movement fails. Changed log.Fatalf to log.Panicf for proper display.
tmeijn
pushed a commit
to tmeijn/dotfiles
that referenced
this pull request
Feb 26, 2025
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [noborus/ov](https://github.com/noborus/ov) | minor | `v0.38.0` -> `v0.39.0` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>noborus/ov (noborus/ov)</summary> ### [`v0.39.0`](https://github.com/noborus/ov/releases/tag/v0.39.0) [Compare Source](noborus/ov@v0.38.0...v0.39.0) #### What's Changed - Add support vertical header and header column by [@​noborus](https://github.com/noborus) in noborus/ov#689 - Fix x start position to not be negative when moving to rightmost cursor by [@​noborus](https://github.com/noborus) in noborus/ov#697 - Improved movement in the document display area by [@​noborus](https://github.com/noborus) in noborus/ov#698 - Add ruler feature by [@​noborus](https://github.com/noborus) in noborus/ov#703 - Add style border by [@​noborus](https://github.com/noborus) in noborus/ov#704 - Add Dependabot configuration by [@​noborus](https://github.com/noborus) in noborus/ov#709 - Bump golang.org/x/term from 0.28.0 to 0.29.0 by [@​dependabot](https://github.com/dependabot) in noborus/ov#712 - Bump github.com/klauspost/compress from 1.17.11 to 1.18.0 by [@​dependabot](https://github.com/dependabot) in noborus/ov#713 - Bump github.com/spf13/cobra from 1.8.1 to 1.9.1 by [@​dependabot](https://github.com/dependabot) in noborus/ov#714 - Bump golang.org/x/sync from 0.10.0 to 0.11.0 by [@​dependabot](https://github.com/dependabot) in noborus/ov#715 - Updated sample config.yaml to the latest version by [@​noborus](https://github.com/noborus) in noborus/ov#719 - Added feature to detect duplicate keybinds by [@​noborus](https://github.com/noborus) in noborus/ov#722 #### New Contributors - [@​dependabot](https://github.com/dependabot) made their first contribution in noborus/ov#712 **Full Changelog**: noborus/ov@v0.38.0...v0.39.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4xODAuMyIsInVwZGF0ZWRJblZlciI6IjM5LjE4MC4zIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiXX0=-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.