Upgrade tcell to v2.8.0 and add support for Underline style and color #680
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
noborus
commented
Jan 10, 2025
- Upgraded tcell to version v2.8.0.
- Added support for Underline style and color in ov.
- Modified oviewer/convert_es.go to handle the new Underline styles and colors.
- Updated oviewer/ovstyle.go to apply the new Underline styles and colors.
- Upgraded other modules.
- Upgraded tcell to version v2.8.0. - Added support for Underline style and color in ov. - Modified oviewer/convert_es.go to handle the new Underline styles and colors. - Updated oviewer/ovstyle.go to apply the new Underline styles and colors. - Upgraded other modules.
ccoVeille
reviewed
Jan 10, 2025
oviewer/ovstyle.go
Outdated
Comment on lines
150
to
153
| return 0 | ||
| } | ||
| if tcell.UnderlineStyle(n) > tcell.UnderlineStyleDashed { | ||
| return 0 |
There was a problem hiding this comment.
Is there no constants for this 0 ?
There was a problem hiding this comment.
Yes, there is. I'll fix it, thanks.
ccoVeille
reviewed
Jan 10, 2025
oviewer/ovstyle.go
Outdated
Comment on lines
144
to
146
| // underLineStyle sets the underline style. | ||
| // only support 0-5. | ||
| // 0: None, 1: Single, 2: Double, 3: Curly, 4: Dotted, 5: Dashed |
There was a problem hiding this comment.
About this
Maybe you could link the constants here with a godoc link
Something like this (pseudo code)
Suggested change
| // underLineStyle sets the underline style. | |
| // only support 0-5. | |
| // 0: None, 1: Single, 2: Double, 3: Curly, 4: Dotted, 5: Dashed | |
| // underLineStyle sets the underline style. | |
| // only support 0-5. | |
| // 0: [tview.WhateverNone], 1: [tview.WhateverSingle], 2: Double, 3: Curly, 4: Dotted, 5: Dashed |
oviewer/ovstyle.go
Outdated
| if err != nil { | ||
| return 0 | ||
| } | ||
| if tcell.UnderlineStyle(n) > tcell.UnderlineStyleDashed { |
There was a problem hiding this comment.
This looks strange
I assume you only wanto support 0-5 range, but these are iota, I assume. So comparing them is a but strange
I would use a switch with the exact value you support in one case.
Also, if you only supports the value "0", "1", maybe you could avoid the string to int conversion
There was a problem hiding this comment.
This is how to do the behavior of an unauthorized value outside the specifications.
The operation changes with Terminal-Emulator, so it may change in the future.
Originally, it is derived from the escape sequence specification, so it doesn't matter much whether it is an iota.
noburus is not a person concerned. 😥
There was a problem hiding this comment.
Wow, a double wrong ping 🤦♂️
Bug fixes in tcell v2.8.0. Update modules.
|
The following is also displayed in Gnome-Terminal. echo "\x1b[4:2m\x1b[58:5:1mHello"|./ov |
Change to UnderlineStyle to match the tcell. Add UnderlineStyle and UnderlineColor to config.yaml and README.md.
tmeijn
pushed a commit
to tmeijn/dotfiles
that referenced
this pull request
Jan 28, 2025
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [noborus/ov](https://github.com/noborus/ov) | minor | `v0.37.0` -> `v0.38.0` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>noborus/ov (noborus/ov)</summary> ### [`v0.38.0`](https://github.com/noborus/ov/releases/tag/v0.38.0) [Compare Source](noborus/ov@v0.37.0...v0.38.0) #### What's Changed - Improve escape sequence compatibility by [@​noborus](https://github.com/noborus) in noborus/ov#656 - Add support for colon-separated values by [@​noborus](https://github.com/noborus) in noborus/ov#657 - Change the range to csiParamStart/csiParamEnd by [@​noborus](https://github.com/noborus) in noborus/ov#659 - Add stdin specification by [@​noborus](https://github.com/noborus) in noborus/ov#661 - Reimplemented osc hyperlink by [@​noborus](https://github.com/noborus) in noborus/ov#664 - Fixed incompatibility in handling invalid osc by [@​noborus](https://github.com/noborus) in noborus/ov#665 - Upgrade tcell to v2.8.0 and add support for Underline style and color by [@​noborus](https://github.com/noborus) in noborus/ov#680 - Add EOF notification feature by [@​noborus](https://github.com/noborus) in noborus/ov#683 - Add function to wait for EOF by [@​noborus](https://github.com/noborus) in noborus/ov#673 - Fix the first position of Follow and Followall by [@​noborus](https://github.com/noborus) in noborus/ov#671 - Fix DocumentLen() out-of-range checks by [@​noborus](https://github.com/noborus) in noborus/ov#675 **Full Changelog**: noborus/ov@v0.37.0...v0.38.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4xMzcuMiIsInVwZGF0ZWRJblZlciI6IjM5LjEzNy4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiXX0=-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.