-
-
Notifications
You must be signed in to change notification settings - Fork 745
doc, types, test: Use Error objects instead of plain objects with replyWithError() #2900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc, types, test: Use Error objects instead of plain objects with replyWithError() #2900
Conversation
…en mimicking Node.js errors
Thank you @okko! |
Same here, I don't know what the use case for that would be, but can't rule it out. I would merge at least #2899 to document usage that better reflects what Node apparently does internally. Then maybe wait with this #2900. On the other hand, reverting this is super easy if someone presents a use case. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, the fix is pretty easy form suer perspective as well, so let's merge this and see if we get any pushback
@okko can you please:
|
@mikicho Thanks! I fixed formatting and enabled the test. I didn't get the 2nd point of your comment, was there a word missing? |
Includes #2899
Fixes #2789