fix: address timeout issue with mocked timers #2880
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leon19
commented
Jun 29, 2025
|
@leon19 I'm wondering if it breaks current workarounds as described in the fixed issue. |
I've added tests for covering the "advance timers" workaround when the timers are mocked, but there is no delay involved |
mikicho
reviewed
Jun 29, 2025
|
@leon19 is it ready for merge? |
mikicho
approved these changes
Jul 25, 2025
Yes, it's ready 👌 |
|
🎉 This PR is included in version 14.0.7 🎉 The release is available on: Your semantic-release bot 📦🚀 |
2 tasks
leon19
added a commit
to leon19/nock
that referenced
this pull request
Aug 7, 2025
This reverts commit fb112f3.
mikicho
pushed a commit
that referenced
this pull request
Aug 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make it work with
sinonandjestfake timers. Fixes #2200Importing
timersinstead of using the global ones would still not work forjest