Skip to content

fix(typescript): filteringBodyRequest #2552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 3, 2023
Merged

fix(typescript): filteringBodyRequest #2552

merged 1 commit into from
Nov 3, 2023

Conversation

stephenprater
Copy link
Contributor

The ambient type in index.d.ts does not match the actual call signature of the filteringRequestBody

This fixes it.

@stephenprater stephenprater force-pushed the fix-filter-body-request-type branch from c33f81d to 9e4ea49 Compare November 3, 2023 05:33
@gr2m gr2m changed the title Fix filteringBodyRequest type fix(typescript): filteringBodyRequest Nov 3, 2023
gr2m
gr2m approved these changes Nov 3, 2023
View reviewed changes
Copy link
Member

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@gr2m gr2m merged commit 0b18d07 into nock:main Nov 3, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 3, 2023

🎉 This PR is included in version 13.3.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ms-bot ms-bot mentioned this pull request Nov 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gr2m gr2m gr2m approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stephenprater @gr2m