Skip to content

Conversation

Uzlopak
Copy link
Member

@Uzlopak Uzlopak commented Oct 17, 2023

We dont have semver as dependency or devDependency. It is only working because semver is installed for another devdependency. Theoretically we should add semver as devdependency to avoid breaking something if we remove the devdependency which uses semver. But we can avoid the necessity to use semver by directly using native code.

@Uzlopak Uzlopak force-pushed the remove-semver-usage branch from 0b26e19 to d5b1cfe Compare October 17, 2023 13:11
@Uzlopak Uzlopak force-pushed the remove-semver-usage branch from d5b1cfe to 09e95c8 Compare October 17, 2023 13:11
Copy link
Member

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch, thank you!

@gr2m gr2m enabled auto-merge (squash) October 19, 2023 17:03
@gr2m gr2m merged commit f7216e9 into nock:main Oct 19, 2023
@github-actions
Copy link

🎉 This PR is included in version 13.3.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

@gr2m
Copy link
Member

gr2m commented Oct 19, 2023

Hmm odd that this merged, despite CI failing for Node 16 🤔

@gr2m
Copy link
Member

gr2m commented Oct 19, 2023

I think I found the culprit: #2538

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants