Skip to content

Add mkdtboimg tool #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 14, 2022
Merged

Add mkdtboimg tool #68

merged 1 commit into from
Oct 14, 2022

Conversation

JamiKettunen
Copy link
Contributor

@JamiKettunen JamiKettunen commented Jul 21, 2022 •
edited
Loading

This is a tool for packing multiple DTB/DTBO files into a single image which is used by bootloader on various Android devices since circa 2017.

libufdt is now tracking tag platform-tools-33.0.3 as #65 has been merged.

@JamiKettunen JamiKettunen marked this pull request as draft July 21, 2022 21:07
@JamiKettunen
Copy link
Contributor Author

@nmeum Any comments? I'd like some feedback to get this merged eventually.

@nmeum
Copy link
Owner

nmeum commented Sep 22, 2022

@nmeum Any comments? I'd like some feedback to get this merged eventually.

I haven't looked into it yet, as I want to upgrade to 33.0.1 first. If you have the time, maybe consider helping out with the remaining compiler issue in #65 so we can move forward with this. My time to work an android-tools is unfortunately a bit limited right now.

If this tool is needed by pmOS, I am a also more than willing to give push access to more pmOS people.

@JamiKettunen
Copy link
Contributor Author

This is indeed already an extra package on postmarketOS: https://gitlab.com/postmarketOS/pmaports/-/tree/master/main/android-mkdtboimg

Unfortunately I don't think I have enough C++ understanding to fix a template error like what's seen in the upgrade PR :/

@JamiKettunen
Add mkdtboimg tool
7354342 
This is a tool for packing multiple DTB/DTBO files into a single image
which is used by bootloader on various Android devices since circa 2017.
@JamiKettunen JamiKettunen marked this pull request as ready for review September 23, 2022 11:32
@JamiKettunen
Copy link
Contributor Author

@nmeum Rebased, the python3 shebang fix also was included in 33.0.3 so no need to potentially patch it here :)

@JamiKettunen
Copy link
Contributor Author

@nmeum Ping

@JamiKettunen JamiKettunen mentioned this pull request Oct 8, 2022
Merged
@anatol
Copy link
Collaborator

anatol commented Oct 10, 2022

@nmeum I do not have objections to including this tool.

Are you OK to move forward with this PR?

@anatol anatol merged commit 0652cba into nmeum:master Oct 14, 2022
@JamiKettunen JamiKettunen deleted the mkdtboimg branch November 23, 2022 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JamiKettunen @nmeum @anatol