Skip to content

CI: Enable 32bit unit test (3) #3532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 14, 2022
Merged

CI: Enable 32bit unit test (3) #3532

merged 6 commits into from
Jun 14, 2022

Conversation

falbrechtskirchinger
Copy link
Contributor

Third time's the charm.

Some of the decision-making logic for whether the 32bit test should be built has been moved into test.cmake and the code for constructing unit tests is now slightly less awkward. When only the 32bit unit test is requested, processing of the CMakeLists.txt is stopped early.

A single-header build has been added to CI.

@coveralls
Copy link

coveralls commented Jun 12, 2022 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling e752352 on falbrechtskirchinger:ci-enable-32bit-test into af34396 on nlohmann:develop.

@falbrechtskirchinger
Copy link
Contributor Author

falbrechtskirchinger commented Jun 12, 2022 •
edited
Loading

@fangq Can you help me out with a test case for this exception (possibly on 32bit only)?
https://github.com/falbrechtskirchinger/json/blob/9ba90f5b70fa9c05978e5ad6c8222f7bf6aaf04f/include/nlohmann/detail/input/binary_reader.hpp#L2083-L2087

I only need a std::vector with the byte sequence. Thanks!

Edit: I think I got it. Waiting for CI…

nlohmann
nlohmann approved these changes Jun 14, 2022
View reviewed changes
Copy link
Owner

@nlohmann nlohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@nlohmann nlohmann added this to the Release 3.11.0 milestone Jun 14, 2022
@nlohmann nlohmann self-assigned this Jun 14, 2022
@nlohmann nlohmann merged commit e80945d into nlohmann:develop Jun 14, 2022
@nlohmann
Copy link
Owner

Thanks a lot!

@nlohmann nlohmann mentioned this pull request Jun 14, 2022
Closed
2 tasks
@falbrechtskirchinger falbrechtskirchinger deleted the ci-enable-32bit-test branch June 14, 2022 07:07
@hahnjo hahnjo mentioned this pull request Aug 17, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlohmann nlohmann nlohmann approved these changes

Assignees

@nlohmann nlohmann

Labels
release item: 🔨 further change
Projects
None yet
Milestone
Release 3.11.0
Development

Successfully merging this pull request may close these issues.
3 participants
@falbrechtskirchinger @coveralls @nlohmann