Skip to content

Add BON8 support #2998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 40 commits into
base: develop
Choose a base branch
from
Draft

Add BON8 support #2998

wants to merge 40 commits into from

Conversation

nlohmann
Copy link
Owner

@nlohmann nlohmann commented Sep 4, 2021

This PR adds support for the BON8 binary format.

See #2980.

Todo:

  • add parser
  • increase coverage
  • add examples from other binary formats
  • add documentation

@nlohmann nlohmann added the aspect: binary formats BSON, CBOR, MessagePack, UBJSON label Sep 4, 2021
@nlohmann nlohmann added this to the Release 3.10.3 milestone Sep 4, 2021
@nlohmann nlohmann self-assigned this Sep 4, 2021
@nlohmann nlohmann marked this pull request as draft September 4, 2021 12:56
@coveralls
Copy link

coveralls commented Sep 4, 2021

Coverage Status

Coverage decreased (-0.2%) to 99.842% when pulling f9003d1 on bon8 into 8fcdbf2 on develop.

@nlohmann nlohmann removed this from the Release 3.10.3 milestone Oct 8, 2021
� Conflicts:
�	doc/mkdocs/docs/api/basic_json/index.md
�	doc/mkdocs/docs/features/binary_formats/bson.md
�	doc/mkdocs/docs/features/binary_formats/index.md
�	doc/mkdocs/mkdocs.yml
�	include/nlohmann/json.hpp
�	single_include/nlohmann/json.hpp
� Conflicts:
�	docs/examples/to_bon8.cpp
�	docs/examples/to_bon8.output
�	docs/mkdocs/docs/api/basic_json/to_bon8.md
�	include/nlohmann/detail/input/binary_reader.hpp
�	include/nlohmann/detail/input/input_adapters.hpp
�	include/nlohmann/detail/output/binary_writer.hpp
�	single_include/nlohmann/json.hpp
�	test/CMakeLists.txt
�	tests/src/unit-binary_formats.cpp
�	tests/src/unit-bon8.cpp
@gregmarr
Copy link
Contributor

@nlohmann @takev Is this still in progress?

@nlohmann
Copy link
Owner Author

It is currently on hold from my side. It's definitely a nice idea for the format, but I currently don't find the time to push this further.

nlohmann added 6 commits June 18, 2022 21:19
� Conflicts:
�	docs/mkdocs/docs/api/basic_json/index.md
�	docs/mkdocs/docs/features/binary_formats/index.md
�	docs/mkdocs/mkdocs.yml
�	tests/src/unit-binary_formats.cpp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aspect: binary formats BSON, CBOR, MessagePack, UBJSON
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants