Skip to content

Fix parent update for diagnostics with ordered_json #2963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 22, 2021
Merged

Fix parent update for diagnostics with ordered_json #2963

merged 2 commits into from
Aug 22, 2021

Conversation

nlohmann
Copy link
Owner

This PR unconditionally updates the diagnostic parent pointers for unordered_json, because there may be invalidated pointers in the underlying std::vector in ordered_map.

Fixes #2962

@nlohmann nlohmann added this to the Release 3.10.1 milestone Aug 20, 2021
@nlohmann nlohmann self-assigned this Aug 20, 2021
This was referenced Aug 20, 2021
Closed
Closed
@coveralls
Copy link

coveralls commented Aug 20, 2021 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 200015c on issue2962 into cb053bc on develop.

@nlohmann nlohmann merged commit c753165 into develop Aug 22, 2021
@nlohmann nlohmann deleted the issue2962 branch August 22, 2021 18:30
@gregmarr gregmarr mentioned this pull request Jan 29, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nlohmann nlohmann

Labels
release item: 🐛 bug fix
Projects
None yet
Milestone
Release 3.10.1
Development

Successfully merging this pull request may close these issues.

JSON_DIAGNOSTICS assertion for ordered_json
2 participants
@nlohmann @coveralls