Skip to content

Skip some tests if JSON_Install is not set #2947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 18, 2021
Merged

Skip some tests if JSON_Install is not set #2947

merged 1 commit into from
Aug 18, 2021

Conversation

nlohmann
Copy link
Owner

If JSON_Install is set to OFF, the following tests fail:

 58 - cmake_import_configure (Failed)
 59 - cmake_import_build (Not Run)
 60 - cmake_import_minver_configure (Failed)
 61 - cmake_import_minver_build (Not Run)

This PR skips them instead if JSON_Install is OFF.

Closes #2946

@nlohmann nlohmann added this to the Release 3.10.1 milestone Aug 18, 2021
@nlohmann nlohmann self-assigned this Aug 18, 2021
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 54d9cd5 on issue2946 into f42a74b on develop.

@nlohmann nlohmann merged commit 5a04042 into develop Aug 18, 2021
@nlohmann nlohmann deleted the issue2946 branch August 18, 2021 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nlohmann nlohmann

Labels
release item: 🔨 further change
Projects
None yet
Milestone
Release 3.10.1
Development

Successfully merging this pull request may close these issues.

ctest (58+60,/67 cmake_import_configure) fails when build with -D JSON_Install:BOOL=OFF because of missing nlohmann_jsonTargets.cmake
2 participants
@nlohmann @coveralls