Skip to content

Adjust CMake minimal version #4709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Apr 1, 2025
Merged

Adjust CMake minimal version #4709

merged 8 commits into from
Apr 1, 2025

Conversation

nlohmann
Copy link
Owner

@nlohmann nlohmann commented Mar 29, 2025 •
edited
Loading

  • Use CMake 4.0.0 in the CI.
  • Change the CMake version range for the project from 
    cmake_minimum_required(VERSION 3.1...3.14)
    to 
    cmake_minimum_required(VERSION 3.5...4.0)
  • Adjust the ci_cmake_flags CI target to use the following CMake versions:
    • CMake 3.5 (the earliest supported)
    • CMake 3.31.6 (the latest 3.x release)
    • CMake 4.0.0 (the latest release)
  • Adjust all test CMake files to use 3.5 as minimal versions
  • Adjust documentation accordingly
  • Off-topic: Added Microsoft Teams to list of customers

@nlohmann
🔧 adjust CMake versions
6320a12 
Signed-off-by: Niels Lohmann <mail@nlohmann.me>
@nlohmann
🔧 install OpenSSL for CMake
cdbb822 
Signed-off-by: Niels Lohmann <mail@nlohmann.me>
@coveralls
Copy link

coveralls commented Mar 29, 2025 •
edited
Loading

Coverage Status

coverage: 99.186%. remained the same
when pulling 255921c on cmake-min-version
into 3a57039 on develop.

nlohmann added 3 commits March 29, 2025 19:09
@nlohmann
🔧 install OpenSSL for CMake
8834708 
Signed-off-by: Niels Lohmann <mail@nlohmann.me>
@nlohmann
🔧 install OpenSSL for CMake
79d05fa 
Signed-off-by: Niels Lohmann <mail@nlohmann.me>
@nlohmann
🔧 install OpenSSL for CMake
34b6e86 
Signed-off-by: Niels Lohmann <mail@nlohmann.me>
@github-actions github-actions bot added the tests label Mar 29, 2025
nlohmann added 3 commits March 30, 2025 08:23
@nlohmann
🔧 install OpenSSL for CMake
b37ac53 
Signed-off-by: Niels Lohmann <mail@nlohmann.me>
@nlohmann
🔨 clean up
013d425 
Signed-off-by: Niels Lohmann <mail@nlohmann.me>
@nlohmann
📝 update documentation
255921c 
Signed-off-by: Niels Lohmann <mail@nlohmann.me>
@nlohmann nlohmann marked this pull request as ready for review March 31, 2025 15:08
@nlohmann nlohmann added this to the Release 3.11.4 milestone Mar 31, 2025
@nlohmann nlohmann added the review needed It would be great if someone could review the proposed changes. label Mar 31, 2025
@nlohmann nlohmann merged commit d41ca94 into develop Apr 1, 2025
132 checks passed
@nlohmann nlohmann deleted the cmake-min-version branch April 1, 2025 12:42
@sovrasov sovrasov mentioned this pull request Apr 3, 2025
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CI CMake documentation M review needed It would be great if someone could review the proposed changes. tests
Projects
None yet
Milestone
Release 3.12.0
Development

Successfully merging this pull request may close these issues.
2 participants
@nlohmann @coveralls