Skip to content

fixes issue 4691 #4693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

bitFiedler
Copy link
Contributor

fixes the behavior in issue 4691
#4691

@bitFiedler bitFiedler requested a review from nlohmann as a code owner March 17, 2025 14:57
@github-actions github-actions bot added the M label Mar 17, 2025
@coveralls
Copy link

coveralls commented Mar 17, 2025

Coverage Status

coverage: 99.186%. remained the same
when pulling 2fe9f3d on bitFiedler:issue-4691-fix_gdb_pretty_printer
into 34665ae on nlohmann:develop.

@bitFiedler bitFiedler force-pushed the issue-4691-fix_gdb_pretty_printer branch from 488b59a to dd4eccf Compare March 17, 2025 15:28
Copy link
Owner

@nlohmann nlohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bitFiedler bitFiedler force-pushed the issue-4691-fix_gdb_pretty_printer branch from dd4eccf to 2e7eb1f Compare March 18, 2025 07:39
Matthias Popp added 4 commits March 18, 2025 08:59
there was a problem in my cLion gdb that comes with python version 3.8.
the pretty printer script do not work because the removeprefix function is added in version 3.9.
therefore we need a fix for that.

Signed-off-by: Matthias Popp <mpopp@arri.at>
…rinter

the indentation size was a mix up, we should use always the same indentation size of 4

Signed-off-by: Matthias Popp <mpopp@arri.at>
easier handling or easier to change

Signed-off-by: Matthias Popp <mpopp@arri.at>
Signed-off-by: Matthias Popp <mpopp@arri.at>
@bitFiedler bitFiedler force-pushed the issue-4691-fix_gdb_pretty_printer branch from 2e7eb1f to 2fe9f3d Compare March 18, 2025 07:59
Copy link
Owner

@nlohmann nlohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@nlohmann nlohmann added this to the Release 3.11.4 milestone Mar 18, 2025
@nlohmann nlohmann linked an issue Mar 18, 2025 that may be closed by this pull request
2 tasks
@nlohmann nlohmann merged commit 7abcb5e into nlohmann:develop Mar 18, 2025
131 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gdb-pretty-print not working with python < 3.9, because of removeprefix
4 participants