-
-
Notifications
You must be signed in to change notification settings - Fork 7.1k
fixes issue 4691 #4693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
nlohmann
merged 4 commits into
nlohmann:develop
from
bitFiedler:issue-4691-fix_gdb_pretty_printer
Mar 18, 2025
Merged
fixes issue 4691 #4693
nlohmann
merged 4 commits into
nlohmann:develop
from
bitFiedler:issue-4691-fix_gdb_pretty_printer
Mar 18, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nlohmann
reviewed
Mar 17, 2025
488b59a
to
dd4eccf
Compare
nlohmann
requested changes
Mar 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check the DCO warning: https://github.com/nlohmann/json/pull/4693/checks?check_run_id=38900328997
dd4eccf
to
2e7eb1f
Compare
there was a problem in my cLion gdb that comes with python version 3.8. the pretty printer script do not work because the removeprefix function is added in version 3.9. therefore we need a fix for that. Signed-off-by: Matthias Popp <mpopp@arri.at>
…rinter the indentation size was a mix up, we should use always the same indentation size of 4 Signed-off-by: Matthias Popp <mpopp@arri.at>
easier handling or easier to change Signed-off-by: Matthias Popp <mpopp@arri.at>
Signed-off-by: Matthias Popp <mpopp@arri.at>
2e7eb1f
to
2fe9f3d
Compare
nlohmann
approved these changes
Mar 18, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes the behavior in issue 4691
#4691