Skip to content

Correct typo in sax_interface.md #4679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 6, 2025
Merged

Conversation

Robadob
Copy link
Contributor

@Robadob Robadob commented Mar 6, 2025

Whilst implementing the saxx interface last night, I found the code example from the documentation had a typographical error, stating the prototype for the binary() method had an argument of type binary rather than binary_t.

binary -> binary_t

binary -> binary_t

Signed-off-by: Robert Chisholm <robert.chisholm@sheffield.ac.uk>
Copy link
Owner

@nlohmann nlohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@nlohmann nlohmann added this to the Release 3.11.4 milestone Mar 6, 2025
@coveralls
Copy link

Coverage Status

coverage: 99.186%. remained the same
when pulling 33e8a6e on Robadob:patch-1
into f3dc468 on nlohmann:develop.

@nlohmann nlohmann merged commit 34665ae into nlohmann:develop Mar 6, 2025
131 checks passed
@nlohmann
Copy link
Owner

nlohmann commented Mar 6, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants