-
-
Notifications
You must be signed in to change notification settings - Fork 7.1k
Closed
Closed
Copy link
Labels
confirmedkind: bugrelease item: 🐛 bug fixsolution: duplicatethe issue is a duplicate; refer to the linked issue insteadthe issue is a duplicate; refer to the linked issue insteadsolution: proposed fixa fix for the issue has been proposed and waits for confirmationa fix for the issue has been proposed and waits for confirmation
Milestone
Description
What is the issue you have?
GCC 7 (on Ubuntu 18.04) doesn't have <filesystem>
, instead, it has <experimental/filesystem>
with namespace std::experimental::filesystem
. When -std=c++17
is specified on Ubuntu 18.04 with GCC-7, this library fails to compile, as
json/include/nlohmann/detail/conversions/from_json.hpp
Lines 22 to 24 in 825d323
#ifdef JSON_HAS_CPP_17 | |
#include <filesystem> | |
#endif |
doesn't work. The inclusion for <filesystem>
requires more care with GCC.
If you experience a compilation error: can you compile and run the unit tests?
- yes
- no - please copy/paste the error message below
/home/runner/work/v6d/v6d/thirdparty/nlohmann-json/include/nlohmann/detail/conversions/from_json.hpp:23:14: fatal error: filesystem: No such file or directory
#include <filesystem>
^~~~~~~~~~~~
compilation terminated.
Metadata
Metadata
Assignees
Labels
confirmedkind: bugrelease item: 🐛 bug fixsolution: duplicatethe issue is a duplicate; refer to the linked issue insteadthe issue is a duplicate; refer to the linked issue insteadsolution: proposed fixa fix for the issue has been proposed and waits for confirmationa fix for the issue has been proposed and waits for confirmation