Add fstest.TestFS #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nlepage
requested changes
Feb 6, 2021
There was a problem hiding this comment.
Hi @cugu
Thanks a lot for your contribution.
I didn't know about testing/fstest! Too bad it isn't even mentioned in io/fs documentation...
I asked for a change in ReadDir's implementation, tell me if it's ok with you.
Otherwise LGTM 👍
|
Release this in v1.0.4 |
|
@all-contributors please add @cugu for tests and code |
|
I've put up a pull request to add @cugu! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nice package, thanks!
Go offers a function to test fs.FS implementations: https://tip.golang.org/pkg/testing/fstest/#TestFS. I added a test for this and fixed the revealed issues.
Sorry for not adding an emoji to the commit message 🙈