Implement numreturned and numresults in XmlQuery #98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tested compatible with OpenWayback. Pywb ignores <request> entirely. I couldn't find any other clients using the XML protocol to test.
We put a limit on the number of records we'll scan to mitigate the query slowdown this causes. Tested compatible with OpenWayback.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We maintain the ability to stream results by moving
<request>after<results>. This change seems to be compatible with both OpenWayback and Pywb. I couldn't find any other clients using the XML protocol to check.In order to prevent runaway slow queries a new
--max-num-resultslimit is added. This limits the number of extra records that will be scanned when calculating the numresults statistic as a safety measure to prevent queries that were fine before this change suddenly becoming much slower. It does not actually limit the actual results returned though so clients can still stream larger result sets than this limit if they request them. In future it might be nice to make this a per-request option.Closes #97. CC @kris-sigur.