WIP: Implement CDXJ storage and retrieval #48
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ato
reviewed
May 6, 2019
| @@ -29,6 +29,7 @@ public static Response queryIndex(Web.Request request, Index index, Iterable<Fil | |||
| Iterable<Capture> captures = query.execute(index); | |||
|
|
|||
| boolean outputJson = "json".equals(request.param("output")); | |||
| // Check request headers for Accept: application/ors+cdxj and write CDXJ instead if requested. | |||
There was a problem hiding this comment.
pywb's CDX server uses a format=cdxj query parameter.
| capture.isCdxj = true; | ||
| capture.timestamp = Long.parseLong(keyVal[1]); | ||
| capture.rawValue = keyVal[2]; | ||
| // parse JSON from capture.rawValue and store in capture.cdxjValue |
There was a problem hiding this comment.
Should also populate the fixed CDX fields from CDXJ equivalents if present?
What do we store on disk, the raw input JSON? A re-searialized (potentially cleaning excess whitespace) version? A more compact encoding like Smile or CBOR? Or perhaps just any extension fields that don't exist in vanilla CDX11?
The latter would keep the index smaller but might lead to rejecting CDXJ inputs if there's a type error (e.g. a string/object/array in an integer field). Might be good to reject them anyway, so we get failures up front at indexing time rather than at (CDX11) query time?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work-in-progress branch for commenting, not for landing (yet).