FIX: Use np.asarray instead of np.array(..., copy=False) #1304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1304 +/- ##
=======================================
Coverage 92.27% 92.27%
=======================================
Files 99 99
Lines 12460 12460
Branches 2561 2561
=======================================
Hits 11497 11497
Misses 641 641
Partials 322 322 ☔ View full report in Codecov by Sentry. |
larsoner
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Numpy 2 is changing
np.array(..., copy=False)to error if the array cannot be made without copying. The semantics we want arenp.asarray(...), which will not make copies if the input is already anndarray.cc @larsoner