ENH: Catch SVD failure and raise informative HeaderDataError #1227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1227 +/- ##
=======================================
Coverage 92.15% 92.15%
=======================================
Files 97 98 +1
Lines 12281 12375 +94
Branches 2525 2543 +18
=======================================
+ Hits 11317 11404 +87
- Misses 647 648 +1
- Partials 317 323 +6 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly targeted at improving logging when an SVD failure arises. We may also want to consider using scipy's SVD when scipy is available, as that allows the option for using the slower but less finicky gesvd algorithm.
No urgency on this, just want to make a patch available to inject into a container.