Skip to content

Conversation

DimitriPapadopoulos
Copy link
Contributor

No description provided.

@@ -284,7 +284,7 @@ def git_pieces_from_vcs(tag_prefix, root, verbose, run_command=run_command):
# TAG-NUM-gHEX
mo = re.search(r'^(.+)-(\d+)-g([0-9a-f]+)$', git_describe)
if not mo:
# unparseable. Maybe git-describe is misbehaving?
# unparsable. Maybe git-describe is misbehaving?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should fix issues in Versioneer in https://github.com/python-versioneer/python-versioneer, rather than making edits here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Copy link
Contributor Author

@DimitriPapadopoulos DimitriPapadopoulos Aug 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that this was fixed in Versioneer just 14 days ago:
python-versioneer/python-versioneer#260

@codecov
Copy link

codecov bot commented Aug 9, 2021

Codecov Report

Merging #1044 (332b6b1) into master (a838238) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1044   +/-   ##
=======================================
  Coverage   92.26%   92.26%           
=======================================
  Files         100      100           
  Lines       12205    12205           
  Branches     2136     2136           
=======================================
  Hits        11261    11261           
  Misses        616      616           
  Partials      328      328           
Impacted Files Coverage Δ
nibabel/gifti/parse_gifti_fast.py 86.06% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a838238...332b6b1. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants