Add TryAdd to SepWriterHeader #311
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #311 +/- ##
=======================================
Coverage 99.58% 99.58%
=======================================
Files 54 54
Lines 4368 4378 +10
Branches 511 513 +2
=======================================
+ Hits 4350 4360 +10
Misses 12 12
Partials 6 6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
nietras
reviewed
Apr 24, 2025
|
Merged, thanks for the pr! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are situations where the user of the library doesn't care if the column already exists. Instead of always throwing an exception an alternative would be to implement a try pattern to ignore additions that would normally cause an error.
The field
SepWriter._colNameToColis only available internally, so the user can not check if a column already exists without an external data structure or catching the exception fromSepWriterHeader.Add.