Skip to content

SepReader: Add async support (C# 13+ only) #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 31 commits into from
Jan 19, 2025
Merged

Conversation

nietras
Copy link
Owner

@nietras nietras commented Jan 12, 2025

Fix #27

Copy link

codecov bot commented Jan 12, 2025

Codecov Report

Attention: Patch coverage is 99.61612% with 2 lines in your changes missing coverage. Please review.

Project coverage is 99.63%. Comparing base (c2e7cd9) to head (9168992).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/Sep/SepReader.IO.Async.cs 99.51% 0 Missing and 1 partial ⚠️
src/Sep/SepReader.IO.Sync.cs 99.51% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #219      +/-   ##
==========================================
+ Coverage   99.58%   99.63%   +0.05%     
==========================================
  Files          47       51       +4     
  Lines        3613     3876     +263     
  Branches      400      433      +33     
==========================================
+ Hits         3598     3862     +264     
+ Misses         13       11       -2     
- Partials        2        3       +1     
Flag Coverage Δ
Debug 99.45% <99.42%> (+0.03%) ⬆️
Release 99.81% <99.69%> (-0.03%) ⬇️
macos-latest 92.69% <99.42%> (+0.53%) ⬆️
ubuntu-latest 99.58% <99.42%> (+0.03%) ⬆️
windows-latest 99.58% <99.42%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nietras nietras changed the title Add async support to Sep SepReader: Add async Support Jan 12, 2025
@nietras nietras changed the title SepReader: Add async Support SepReader: Add async support Jan 19, 2025
@nietras nietras changed the title SepReader: Add async support SepReader: Add async support (C# 13+ only) Jan 19, 2025
@nietras nietras merged commit f92b65b into main Jan 19, 2025
32 checks passed
@nietras nietras deleted the sepreader-add-async-support branch January 19, 2025 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sep does not support async only streams (such as IBrowserFile)
1 participant