Assume unpushed if unable to resolve ref from short name #215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
881659f to
66543ba
Compare
- When checking if unpushed and attempting to resolve the reference from
a short name, ignore the error and assume we need to push
- For now, the error is logged to stderr at the debug level, but we
may need to perform more advanced error handling in the future
- Use tempfile instead of creating directories under "target"
- The root temporary directory and its descendants will be immediately
deleted as soon as the value for root is dropped from scope
- This is far less error prone than the previous method
- Remove bors to increase developer and release feedback loop
Signed-off-by: Nick Gerace <nickagerace@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The behavior identified in #202 occurs because the constructed remote name (
<remote>/<local-branch-name>) is assumed to exist. This will not always be the case, and will never (likely?) be the case when working onHEAD.Closes #202
Closes #213