Add support for '*_name
attributes of generate block label
#1126
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a bit of fun trying to fix issue #1125 as it seemed rather simple.
The basic stuff works. But some other does not:
gen_case
andgen_case_true
would both resolve togen_case_true
.'path_name
is accessed from outside the generate block, instead of returning e.g.:issue1125:gen_case:
it returns only:issue1125:
gen_for
label if we are outside the loop. Inside we havegen_for(0)
,gen_for(1)
, etc. But outside? Onlygen_for
?gen_for(1)
and sometimesgen_for
. So it does not seem very important.Let me know if you see another way of implementing it. Please feel also absolutely free to discard everything and implement your own fix.
Cheers
Fixes #1125