fix: set wrong time when setting time range if use time step (fix #65) #67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwlee1108
approved these changes
Aug 25, 2021
src/js/timepicker/index.js
Outdated
| @@ -768,8 +768,16 @@ var TimePicker = defineClass( | |||
| * @private | |||
| */ | |||
| applyRange: function(beginHour, beginMin, endHour) { | |||
| var toSetHour = beginHour; | |||
There was a problem hiding this comment.
변수명이 약간 어색하네요. 그냥 hour나 minute로 해도 괜찮을 것 같은데 이건 단순 아이디어이니 반영 안하셔도 돼요~
There was a problem hiding this comment.
저도 이런 상황에서는 target 이라는 접두사를 더 많이 사용해서 그런지 어색하네요.
There was a problem hiding this comment.
접두사를 toSet에서 target으로 변경했습니다.
단순히 hour와 minute로 사용하니 정확히 어디에 쓰이는 변수인지 알기 조금 어려운 느낌이 있어 제시해주신 접두사를 붙이는 것으로 했습니다.
adhrinae
approved these changes
Aug 25, 2021
src/js/timepicker/index.js
Outdated
| @@ -768,8 +768,16 @@ var TimePicker = defineClass( | |||
| * @private | |||
| */ | |||
| applyRange: function(beginHour, beginMin, endHour) { | |||
| var toSetHour = beginHour; | |||
There was a problem hiding this comment.
저도 이런 상황에서는 target 이라는 접두사를 더 많이 사용해서 그런지 어색하네요.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
fix #xxx[,#xxx], where "xxx" is the issue number)Description
Thank you for your contribution to TOAST UI product. 🎉 😘 ✨