refactor: remove handlebars #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

heenakwag merged 18 commits into master from refactor/remove-handlebars

Dec 19, 2019

Member

heenakwag commented Nov 18, 2019 •

edited

Loading

Use tui.code-snippet template instead of handlebars
- The reason why removing handlebars: chore(deps-dev): bump handlebars from 4.0.6 to 4.1.2 #39
Apply tui.code-snippet@2.2.0
Remove handlebars and tui-dom

heenakwag added 10 commits

November 7, 2019 17:44


          feat: replace expressions depending on the context

296a941


          feat: execute a helper function with arguments

b74fbd1


          feat: add helper - if

fe94e2c


          feat: add helper - each

32354a7


          feat: find value in the context by an expression

5c16313


          feat: add helper - with ... as

d845786


          feat: add helper - elseif, else

85652c5


          feat: duplicate block helpers

3e930f0


          refactor: use template.js instead of hbs

47e8b99


          chore: remove handlebars

e8622f8

seonim-ryu reviewed

View reviewed changes

src/js/util.js Outdated Show resolved Hide resolved

seonim-ryu reviewed

View reviewed changes

src/template/template.js Outdated Show resolved Hide resolved

jung-han reviewed

View reviewed changes

src/template/template.js Outdated Show resolved Hide resolved

jung-han reviewed

View reviewed changes

src/template/template.js Outdated Show resolved Hide resolved

seonim-ryu reviewed

View reviewed changes

src/template/template.js Outdated Show resolved Hide resolved

seonim-ryu reviewed

View reviewed changes

src/template/template.js Outdated Show resolved Hide resolved

jung-han reviewed

View reviewed changes

src/template/template.js Outdated Show resolved Hide resolved

seonim-ryu reviewed

View reviewed changes

src/template/template.js Outdated Show resolved Hide resolved

seonim-ryu reviewed

View reviewed changes

src/template/template.js Outdated Show resolved Hide resolved

jung-han approved these changes

View reviewed changes

Member

jung-han left a comment

리뷰 완료입니다~

Member

seonim-ryu commented Nov 18, 2019

[11/18] 리뷰 완료합니다. 템플릿 모듈 만드는게 간단하지 않은 작업인데 고생 많았어요~ 👍

seonim-ryu approved these changes

View reviewed changes

heenakwag added 3 commits

November 19, 2019 09:42


          chore: apply code review

1a30c17


          refactor: apply code-snippet@2.1.0

a0995d7


          chore: change directory structure

bcfd4f4

seonim-ryu reviewed

View reviewed changes

src/js/timepicker/index.js Outdated Show resolved Hide resolved

seonim-ryu reviewed

View reviewed changes

src/js/timepicker/index.js Show resolved Hide resolved

jung-han reviewed

View reviewed changes

src/js/util.js Outdated Show resolved Hide resolved

jung-han approved these changes

View reviewed changes

Member

jung-han left a comment

리뷰 완료입니다~

seonim-ryu approved these changes

View reviewed changes

Member

seonim-ryu left a comment

[12/2] 리뷰 완료합니다. ES6였다면 모듈 가져오는 코드가 좀 더 깔끔해졌을텐데 아쉽군요 ;ㅅ; ES6로 올리는 작업은 차후에 작업하기로 해요ㅎㅎ 고생 많으셨어요 👍

jung-han mentioned this pull request

refactor: remove handlebars nhn/tui.date-picker#56

Merged

4 tasks

heenakwag added 3 commits

December 12, 2019 10:16


          chore: apply code review

745dcac


          chore: apply tui-code-snippet@2.2.0

b2a0b7c


          chore: set webpack optimization

0e5a5b5

heenakwag force-pushed the refactor/remove-handlebars branch from 5f274ec to 0e5a5b5 Compare

December 12, 2019 02:49

heenakwag added 2 commits

December 19, 2019 11:44


          chore: apply code review

e67a13c


          chore: update dependencies

1b10ba9

heenakwag merged commit 8500615 into master

heenakwag deleted the refactor/remove-handlebars branch

December 19, 2019 02:46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet