Skip to content

Conversation

jajugoguma
Copy link
Contributor

Please check if the PR fulfills these requirements

  • It's submitted to right branch according to our branching model
  • It's right issue type on title
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • It does not introduce a breaking change or has description for the breaking change

Description

  • Fixed an issue that the previous or next year buttons would not appear even though there were selectable years.
    • If you look at the picture below, in the past, the previous/next page buttons appeared only when you could select before 2013/after 2031.
    • However, even if it was selectable from 2014 to 2017 and 2027 to 2030, the previous/next page buttons did not appear.
    • This criterion has been changed to whether the year closest to the current one can be selected, rather than whether the year in the middle of the previous/next page can be selected.
    • So if there is even one selectable year on the previous/next page, the button appears.

image


Thank you for your contribution to TOAST UI product. 🎉 😘 ✨

@jajugoguma jajugoguma self-assigned this Nov 21, 2022
@adhrinae adhrinae self-requested a review November 22, 2022 00:54
Copy link

@jwlee1108 jwlee1108 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수정 전: 2018 ~ 2026 → 2027 ~ 2035
수정 후: 2018 ~ 2026 → 2023 ~ 2031

이렇게 수정하면 Next로 넘겨도 2023~2026년이 겹쳐 보이게 되네요. 이걸 의도한건가요?

Copy link

@jwlee1108 jwlee1108 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이건 테스트를 만들라면 그 다음 스텝이 더 적절할까요?

Copy link

@adhrinae adhrinae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 견본을 확인해볼만한 예제가 있음 더 좋겠지만요.

@jajugoguma jajugoguma merged commit f53606b into master Nov 23, 2022
@jajugoguma jajugoguma deleted the fix/prev-or-next-year-button-not-appear branch November 23, 2022 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants