fix: touch below element after touch today button in smartphone #91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore: remove 'today' event
jajugoguma
commented
Sep 16, 2021
| @@ -144,8 +142,6 @@ var Header = defineClass( | |||
|
|
|||
| if (closest(target, SELECTOR_BTN)) { | |||
| this.fire('click', ev); | |||
| } else if (closest(target, TODAY_TITLE_ELEM)) { | |||
| this.fire('today'); | |||
There was a problem hiding this comment.
today 이벤트는 v4.3.0에서 today 버튼 기능 구현을 위해 추가한 이벤트 입니다.
그러나 구현 방법의 변경으로 인해 내부적으로 더 이상 today 이벤트가 필요하지 않게 되었습니다.
해당 이벤트를 삭제해도 되는지 궁금합니다!
There was a problem hiding this comment.
@lja1018 넵, 외부로 나가지 않는 이벤트여서 저도 삭제하는 것으로 작업 했습니다.
lja1018
approved these changes
Sep 30, 2021
| @@ -144,8 +142,6 @@ var Header = defineClass( | |||
|
|
|||
| if (closest(target, SELECTOR_BTN)) { | |||
| this.fire('click', ev); | |||
| } else if (closest(target, TODAY_TITLE_ELEM)) { | |||
| this.fire('today'); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
fix #xxx[,#xxx], where "xxx" is the issue number)Description
clickevent rather than implementing it through atodayevent.As-Is
To-Be
Thank you for your contribution to TOAST UI product. 🎉 😘 ✨