fix: touch below element together in smartphone (fix #78) #86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adhrinae
reviewed
Jul 5, 2021
src/js/datepicker/index.js
Outdated
| * @private | ||
| */ | ||
| _onTouchStartHandler: function(ev) { | ||
| ev.preventDefault(); |
There was a problem hiding this comment.
혹시 별도의 이벤트 추가/제거를 아예 빼버리고 _onClickHandler 최상단에 ev.preventDefault() 를 호출하는 방식으로는 안되던가요? 굳이 불필요한 리스너를 추가하는 느낌이 드네요.
There was a problem hiding this comment.
해당 방법 정상 동작하는 것 확인해서 알려주신 방법으로 변경했습니다.
터치 이벤트의 동작에 대해 찾아서 한 번 정리해 보도록 하겠습니다.
There was a problem hiding this comment.
터치 관련 이벤트가 onClick보다 먼저 발생하는 걸로 알고 있어서 동작은 할텐데요. 저도 불필요한 이벤트 핸들러를 추가한 느낌이네요.
근데 PR 설명만 봤을때.. 팝업과 전혀 별개의 요소로 보이는데 클릭이 되는게 좀 이상하네요..근본적으로 이벤트가 어느 범위까지 걸려서 작동하는지 확인하고 수정해야 명확할 것 같습니다~!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
fix #xxx[,#xxx], where "xxx" is the issue number)Description
As-Is
To-Be
Thank you for your contribution to TOAST UI product. 🎉 😘 ✨