fix: slider works properly when the size changed #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lja1018
requested changes
Jun 10, 2022
src/js/slider.js
Outdated
| var sliderRects = this.sliderSvgElement.getClientRects()[0]; | ||
|
|
||
| if (sliderRects) { | ||
| COLORSLIDER_POS_LIMIT_RANGE[1] = sliderRects.height - 10; |
There was a problem hiding this comment.
상수 값을 바꾸는 것보단 min, max 계산 시 처리하는게 나을 것 같아요.
src/js/slider.js
Outdated
| @@ -170,6 +172,11 @@ Slider.prototype.render = function(colorStr) { | |||
| Slider.prototype._moveColorSliderHandle = function(newLeft, newTop, silent) { | |||
There was a problem hiding this comment.
지금 마우스 움직일 때마다 getClientRects가 호출되는데 클릭 시작 시 혹은 드래그 시작 시에 1번만 호출되야할 것 같아요.
There was a problem hiding this comment.
이름은 슬라이더가 움직일 때마다 호출되는 함수 같은데 전체 코드상 맞는지 확인 부탁드려요.
adhrinae
reviewed
Jun 10, 2022
src/js/slider.js
Outdated
| var sliderRects = this.sliderSvgElement.getClientRects()[0]; | ||
|
|
||
| if (sliderRects) { | ||
| COLORSLIDER_POS_LIMIT_RANGE[1] = sliderRects.height - 10; |
There was a problem hiding this comment.
기존에는 변하지 않을 값이라 생각해서 전부 대문자인 상수 변수로 처리한거같은데 이제 상황에 따라 동적으로 재할당되어야하는 상황이 되었으니 변수 네이밍 변경이 되었으면 좋겠네요. 나머지는 별 이견 없습니다.
jwlee1108
reviewed
Jun 13, 2022
src/js/slider.js
Outdated
| @@ -170,6 +172,11 @@ Slider.prototype.render = function(colorStr) { | |||
| Slider.prototype._moveColorSliderHandle = function(newLeft, newTop, silent) { | |||
There was a problem hiding this comment.
이름은 슬라이더가 움직일 때마다 호출되는 함수 같은데 전체 코드상 맞는지 확인 부탁드려요.
chore: change constants to variables chore: set sliders maximum pos when drag starts
adhrinae
approved these changes
Jun 14, 2022
|
@adhrinae |
|
@jajugoguma |
|
@adhrinae |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
fix #xxx[,#xxx], where "xxx" is the issue number)Description
As-Is
To-Be
Thank you for your contribution to TOAST UI product. 🎉 😘 ✨