chore: migrate tests from karma to jest #52
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore: remove karma-jasmine test environment
lja1018
reviewed
Jun 11, 2021
jest.config.js
Outdated
| module.exports = { | ||
| moduleFileExtensions: ['js'], | ||
| testEnvironment: 'jsdom', | ||
|
|
Comment on lines
+518
to
+521
| { | ||
| _id: 4, | ||
| value: 2 | ||
| }, |
There was a problem hiding this comment.
린트 룰(prettier/prettier)에 의해서 해당 형태로 자동 변환됩니다!
test/core/view.spec.js
Outdated
Comment on lines
85
to
86
| var spy, | ||
| spyMock = jest.fn(); |
There was a problem hiding this comment.
여긴
var spy;
var spyMock = jest.fn();
이 좋을 것 같습니다.
test/core/view.spec.js
Outdated
Comment on lines
215
to
216
| var view2, | ||
| spy = jest.fn(); |
test/core/view.spec.js
Outdated
Comment on lines
232
to
234
| var view2, | ||
| view3, | ||
| spy = jest.fn(); |
adhrinae
approved these changes
Jun 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
fix #xxx[,#xxx], where "xxx" is the issue number)Description
Thank you for your contribution to TOAST UI product. 🎉 😘 ✨