Skip to content

Fix: two or more instances (fix #10) #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 7, 2019
Merged

Fix: two or more instances (fix #10) #23

merged 2 commits into from
Nov 7, 2019

Conversation

heenakwag
Copy link
Member

  • add generateId() to factory.js to create an unique id for a color-picker instance.
  • use an unique id to create a slider component.

jung-han
jung-han approved these changes Nov 7, 2019
View reviewed changes
Copy link
Member

@jung-han jung-han left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰완료입니다! 고생하셨어요

@heenakwag heenakwag merged commit 28c1de4 into master Nov 7, 2019
@heenakwag heenakwag deleted the fix/two-or-more-instances branch November 7, 2019 06:37
@heenakwag heenakwag mentioned this pull request Nov 7, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@jung-han jung-han jung-han approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@heenakwag @jung-han