Skip to content

fix ts strict mode #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 14, 2025
Merged

fix ts strict mode #186

merged 2 commits into from
Jul 14, 2025

Conversation

ngxson
Copy link
Owner

@ngxson ngxson commented Jul 14, 2025 •
edited by coderabbitai bot
Loading

Fix regression from #178 that cause compilation to fail

Summary by CodeRabbit

  • New Features

    • Added new parameters to sampling configuration, including support for mirostat_eta, samplers_sequence, and typ_p.
    • Model loading now enforces single sequence support.

  • Improvements

    • All optional fields in TypeScript interfaces now explicitly include | undefined for clearer type definitions.
    • Logit bias tokens and values are now handled as separate arrays for improved clarity during sampling initialization.

@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Jul 14, 2025 •
edited
Loading

Walkthrough

This change updates the TypeScript interface generation and usage for nullable or optional fields. Generated interfaces now explicitly include | undefined for optional properties. The SamplingConfig interface is expanded, and the model loading and sampling initialization logic is adjusted to handle logit bias tokens and values as separate arrays.

Changes

File(s) Change Summary
cpp/generate_glue_prototype.js Modified TypeScript interface generation: nullable fields now marked optional and typed as `T
src/glue/messages.ts Updated all optional interface properties to explicitly include `
src/wllama.ts Expanded SamplingConfig with new fields, explicit `

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Wllama
    participant NativeLayer

    User->>Wllama: loadModel(config)
    Wllama->>NativeLayer: wllamaAction('load', {..., n_seq_max: 1})
    NativeLayer-->>Wllama: Model loaded

    User->>Wllama: samplingInit(samplingConfig)
    Wllama->>Wllama: Extract logit_bias_toks/vals from samplingConfig
    Wllama->>NativeLayer: wllamaAction('sampling_init', {..., logit_bias_toks, logit_bias_vals})
    NativeLayer-->>Wllama: Sampling initialized
Loading

Possibly related PRs

  • Strict tsconfig.json #178: Both PRs modify TypeScript interface optional properties to explicitly include | undefined in src/glue/messages.ts, reflecting a shared focus on precise nullable/optional type annotations.

Poem

A bunny with code on its mind,
Adds | undefined—so easy to find!
Types are now clear,
No more hidden fear,
Interfaces neat, and logic aligned.

(🐇✨)

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4878069 and 4e5e225.

📒 Files selected for processing (3)
  • cpp/generate_glue_prototype.js (1 hunks)
  • src/glue/messages.ts (3 hunks)
  • src/wllama.ts (3 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: test (ubuntu-latest, 22)
🔇 Additional comments (7)
cpp/generate_glue_prototype.js (1)

105-105: LGTM! Essential fix for TypeScript strict mode compatibility.

This change ensures that nullable fields in generated TypeScript interfaces explicitly include | undefined, which is required for proper type safety in strict mode. The fix addresses the root cause of the TypeScript compilation regression.

src/wllama.ts (3)

122-141: LGTM! Consistent TypeScript strict mode compatibility updates.

The explicit | undefined additions to all optional properties in the SamplingConfig interface align with the broader changes to fix TypeScript strict mode issues. This ensures type safety consistency across the codebase.

619-619: LGTM! Adding support for sequence limit parameter.

The n_seq_max: 1 parameter addition corresponds to the interface changes and maintains single sequence support as documented in the comment.

846-855: LGTM! Proper handling of logit bias arrays.

The changes correctly extract logit bias tokens and values into separate arrays (logit_bias_toks and logit_bias_vals) to match the updated interface structure. This maintains functionality while conforming to the new type definitions.

src/glue/messages.ts (3)

1003-1015: LGTM! Generated code correctly implements strict mode type safety.

The explicit | undefined additions to optional properties in the GlueMsgLoadReq interface are correctly generated and align with TypeScript strict mode requirements.

1055-1076: LGTM! Comprehensive type safety improvements.

The GlueMsgSamplingInitReq interface updates correctly implement explicit | undefined for all optional properties, ensuring consistent type safety across the sampling configuration.

1320-1320: LGTM! Consistent type safety pattern.

The add_ass property correctly includes explicit | undefined typing, maintaining consistency with the rest of the interface updates.

✨ Finishing Touches
  • 📝 Generate Docstrings
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@ngxson ngxson merged commit 355db70 into master Jul 14, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ngxson