Fix: ZoneSync delays in some installations caused problems #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p-pautov
reviewed
Apr 14, 2022
p-pautov
reviewed
Apr 15, 2022
p-pautov
reviewed
Apr 16, 2022
alebastr
reviewed
Apr 16, 2022
alebastr
approved these changes
Apr 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: ZoneSync delays in some installations caused problems
Fix is slowing down the request processing in case the zone sync is not fast enough. This issue may occur in environments where NGINX cluster nodes can randomly process requests from user agents and there may be a situation where node "A" successfully received a token, and node "B" receives the next request in less than zone_sync_interval.
Introduced
zone_sync_leewayvariable that specifies the maximum timeout for synchronizing ID tokens between cluster nodes. The request doesn't wait until it reaches the timeout, if the "session_jwt" variable "appeared" in key-value database before the timeout expires, the request will be released.Fix: Double URL encoding in proxy upstream after internalRedirect
In some cases the
r.internalRedirect(uri)will double encode the URI. This problem may occur if OIDC module needs to update the set of tokens using the refresh token and redirect the user agent to the original request URI.