Skip to content

Pin app protect version #7298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 6, 2025
Merged

Pin app protect version #7298

merged 4 commits into from
Feb 6, 2025

Conversation

pdabelf5
Copy link
Collaborator

@pdabelf5 pdabelf5 commented Feb 6, 2025 •
edited
Loading

Proposed changes

  • pin nginx-plus-module-appprotect to the same version as app-protect-module-plus to 5.210
  • revert to ubuntu-22.04 runners
  • fix jq syntax for ubuntu-22.04

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@pdabelf5 pdabelf5 requested a review from a team as a code owner February 6, 2025 11:14
@github-actions github-actions bot added github_actions Pull requests that update Github_actions code docker Pull requests that update Docker code chore Pull requests for routine tasks labels Feb 6, 2025
@pdabelf5 pdabelf5 merged commit 5635d68 into main Feb 6, 2025
80 checks passed
@pdabelf5 pdabelf5 deleted the pin-app-protect-version branch February 6, 2025 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexFenlon AlexFenlon AlexFenlon approved these changes

@jjngx jjngx jjngx approved these changes

Assignees
No one assigned
Labels
chore Pull requests for routine tasks docker Pull requests that update Docker code github_actions Pull requests that update Github_actions code
Projects
NGINX Ingress Controller
Status: Done 🚀
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pdabelf5 @AlexFenlon @jjngx