Skip to content

Correct typo in helm lease annotations template #7185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 22, 2025
Merged

Conversation

pdabelf5
Copy link
Collaborator

@pdabelf5 pdabelf5 commented Jan 22, 2025

Proposed changes

The syntax for the helm template controller-lease.yaml was incorrect for annotations. This change addresses the issue by adding the required : to make the yaml valid.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@pdabelf5 pdabelf5 requested a review from a team as a code owner January 22, 2025 10:14
@github-actions github-actions bot added the helm_chart Pull requests that update the Helm Chart label Jan 22, 2025
@pdabelf5 pdabelf5 linked an issue Jan 22, 2025 that may be closed by this pull request
@pdabelf5 pdabelf5 changed the title fix typo in helm lease annotations template Correct typo in helm lease annotations template Jan 22, 2025
@pdabelf5 pdabelf5 added the needs cherry pick Cherry pick this PR into a release branch label Jan 22, 2025
@pdabelf5 pdabelf5 merged commit ec4acee into main Jan 22, 2025
71 checks passed
@pdabelf5 pdabelf5 deleted the lease-annotations branch January 22, 2025 11:44
@pdabelf5 pdabelf5 added bug An issue reporting a potential bug and removed helm_chart Pull requests that update the Helm Chart needs cherry pick Cherry pick this PR into a release branch labels Apr 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue reporting a potential bug
Projects
Status: Done 🚀
Development

Successfully merging this pull request may close these issues.

[Bug]: Typo in templates/controller-lease.yaml
4 participants