Skip to content

Pin OSS version in Dockerfile #7990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 4, 2025
Merged

Pin OSS version in Dockerfile #7990

merged 1 commit into from
Jul 4, 2025

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jul 4, 2025

Proposed changes

Pin OSS version in Dockerfile, current version is 1.27. This ensures when modules are installed nginx is not also upgraded to match the latest module version.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@github-actions github-actions bot added chore Pull requests for routine tasks docker Pull requests that update Docker code needs cherry pick Cherry pick this PR into a release branch labels Jul 4, 2025
@github-actions github-actions bot requested a review from a team as a code owner July 4, 2025 12:19
@github-actions github-actions bot added docker Pull requests that update Docker code chore Pull requests for routine tasks needs cherry pick Cherry pick this PR into a release branch labels Jul 4, 2025
@pdabelf5 pdabelf5 removed docker Pull requests that update Docker code needs cherry pick Cherry pick this PR into a release branch labels Jul 4, 2025
@pdabelf5 pdabelf5 closed this Jul 4, 2025
@pdabelf5 pdabelf5 reopened this Jul 4, 2025
@github-actions github-actions bot added the docker Pull requests that update Docker code label Jul 4, 2025
@pdabelf5 pdabelf5 enabled auto-merge (squash) July 4, 2025 12:20
@pdabelf5 pdabelf5 changed the title [cherry-pick] Pin OSS version in Dockerfile Pin OSS version in Dockerfile Jul 4, 2025
@pdabelf5 pdabelf5 disabled auto-merge July 4, 2025 12:20
@pdabelf5 pdabelf5 enabled auto-merge (squash) July 4, 2025 12:21
javorszky
javorszky approved these changes Jul 4, 2025
View reviewed changes
Copy link
Contributor

@javorszky javorszky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we're pinning these to 1.27 rather than 1.29 because alpine doesn't have 1.29 available yet?

@codecov Codecov
Copy link

codecov bot commented Jul 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-5.1@adbb5e6). Learn more about missing BASE report.

Additional details and impacted files 
@@              Coverage Diff               @@
##             release-5.1    #7990   +/-   ##
==============================================
  Coverage               ?   52.95%           
==============================================
  Files                  ?       90           
  Lines                  ?    21729           
  Branches               ?        0           
==============================================
  Hits                   ?    11506           
  Misses                 ?     9746           
  Partials               ?      477

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pdabelf5 pdabelf5 merged commit 9fccbca into release-5.1 Jul 4, 2025
72 checks passed
@pdabelf5 pdabelf5 deleted the cherry-pick-release-5.1-4ea82ac94888a3d266a2589d66039769424febd4 branch July 4, 2025 12:58
@pdabelf5
Copy link
Collaborator

pdabelf5 commented Jul 4, 2025

we're pinning these to 1.27 rather than 1.29 because alpine doesn't have 1.29 available yet?

No, because the alpine base image for NGINX 1.29.0 is Alpine 3.22. We cannot yet update to this Alpine version as NGINX Agent 3.x does not yet support 3.22.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javorszky javorszky javorszky approved these changes

@vepatel vepatel vepatel approved these changes

@pdabelf5 pdabelf5 pdabelf5 approved these changes

Assignees
No one assigned
Labels
chore Pull requests for routine tasks docker Pull requests that update Docker code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pdabelf5 @javorszky @vepatel