Skip to content

Correct namespace for mgmt secrets #7786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 20, 2025
Merged

Correct namespace for mgmt secrets #7786

merged 5 commits into from
May 20, 2025

Conversation

pdabelf5
Copy link
Collaborator

@pdabelf5 pdabelf5 commented May 14, 2025 •
edited
Loading

Proposed changes

The secret is in the NIC namespace, not the ConfigMap namespace. Helm puts the ConfigMap in the same namespace as NIC so it's not a problem unless manifests are used.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@pdabelf5 pdabelf5 requested a review from a team as a code owner May 14, 2025 16:39
@github-actions github-actions bot added bug An issue reporting a potential bug go Pull requests that update Go code labels May 14, 2025
@codecov Codecov
Copy link

codecov bot commented May 14, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 52.29%. Comparing base (a18885a) to head (cf6077c).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/k8s/controller.go 0.00% 6 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #7786   +/-   ##
=======================================
  Coverage   52.29%   52.29%           
=======================================
  Files          90       90           
  Lines       21472    21472           
=======================================
  Hits        11228    11228           
  Misses       9774     9774           
  Partials      470      470

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jjngx jjngx merged commit 2f20368 into main May 20, 2025
81 checks passed
@jjngx jjngx deleted the fix/mgmt-namespace branch May 20, 2025 09:20
pdabelf5 added a commit that referenced this pull request May 22, 2025
@pdabelf5
correct namespace for mgmt secrets (#7786)
93cf222
@AlexFenlon AlexFenlon changed the title correct namespace for mgmt secrets Correct namespace for mgmt secrets Jun 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vepatel vepatel vepatel approved these changes

@AlexFenlon AlexFenlon AlexFenlon approved these changes

@jjngx jjngx jjngx approved these changes

Assignees
No one assigned
Labels
bug An issue reporting a potential bug go Pull requests that update Go code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pdabelf5 @vepatel @AlexFenlon @jjngx