Skip to content

Remove s390x, arm/7 and ppc64le #7784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 14, 2025
Merged

Remove s390x, arm/7 and ppc64le #7784

merged 5 commits into from
May 14, 2025

Conversation

AlexFenlon
Copy link
Contributor

Proposed changes

  • remove building and publishing of the s390x, arm/7 and ppc64le architechure binaries.

Note
Users can still build and run NIC using these images.

eg.
NGINX Ingress Controller Version=5.0.0 Commit=179ad349fc4ffe316b881f9c376114ce57c9c82d Date=2025-05-13T13:11:50Z DirtyState=true Arch=linux/s390x Go=go1.24.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@AlexFenlon AlexFenlon requested a review from pdabelf5 May 14, 2025 13:39
@AlexFenlon AlexFenlon requested review from a team as code owners May 14, 2025 13:39
@github-actions github-actions bot added documentation Pull requests/issues for documentation github_actions Pull requests that update Github_actions code chore Pull requests for routine tasks labels May 14, 2025
@github-actions GitHub Actions
Copy link
Contributor

✅ Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/nginx-ingress-controller/7784/

pdabelf5
pdabelf5 reviewed May 14, 2025
View reviewed changes
@AlexFenlon
Update .goreleaser.yml
417d53a 
Signed-off-by: AlexFenlon <a.fenlon@f5.com>
pdabelf5
pdabelf5 reviewed May 14, 2025
View reviewed changes
@codecov Codecov
Copy link

codecov bot commented May 14, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.34%. Comparing base (179ad34) to head (b1862b2).
Report is 3 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #7784      +/-   ##
==========================================
+ Coverage   52.32%   52.34%   +0.01%     
==========================================
  Files          89       89              
  Lines       21373    21373              
==========================================
+ Hits        11184    11188       +4     
+ Misses       9721     9719       -2     
+ Partials      468      466       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@AlexFenlon AlexFenlon enabled auto-merge (squash) May 14, 2025 14:56
@AlexFenlon AlexFenlon merged commit c07da1c into main May 14, 2025
85 checks passed
@AlexFenlon AlexFenlon deleted the remove-archs branch May 14, 2025 14:59
@github-project-automation github-project-automation bot moved this from Todo ☑ to Done 🚀 in NGINX Ingress Controller May 14, 2025
@AlexFenlon AlexFenlon self-assigned this May 14, 2025
haywoodsh pushed a commit that referenced this pull request May 15, 2025
@AlexFenlon @haywoodsh
remove s390x, arm/7 and ppc64le (#7784)
bf36590
@AlexFenlon AlexFenlon changed the title remove s390x, arm/7 and ppc64le Remove s390x, arm/7 and ppc64le Jun 23, 2025
@AlexFenlon AlexFenlon removed documentation Pull requests/issues for documentation github_actions Pull requests that update Github_actions code labels Jun 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ADubhlaoich ADubhlaoich ADubhlaoich approved these changes

@vepatel vepatel vepatel approved these changes

@jjngx jjngx jjngx approved these changes

@pdabelf5 pdabelf5 pdabelf5 approved these changes

Assignees

@AlexFenlon AlexFenlon

Labels
chore Pull requests for routine tasks
Projects
NGINX Ingress Controller
Status: Done 🚀
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AlexFenlon @ADubhlaoich @vepatel @jjngx @pdabelf5