Skip to content

Add oidc refactor commit from ref impl #7762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 8, 2025
Merged

Add oidc refactor commit from ref impl #7762

merged 4 commits into from
May 8, 2025

Conversation

vepatel
Copy link
Contributor

@vepatel vepatel commented May 7, 2025 •
edited
Loading

Proposed changes

local build passes both OIDC automation test:

======================================================== 2 passed, 571 deselected, 24 warnings in 299.89s (0:04:59) =========================================================

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@vepatel vepatel requested a review from a team as a code owner May 7, 2025 15:35
@codecov Codecov
Copy link

codecov bot commented May 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.34%. Comparing base (f4ed950) to head (eb1b48b).
Report is 4 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #7762   +/-   ##
=======================================
  Coverage   52.34%   52.34%           
=======================================
  Files          89       89           
  Lines       21373    21373           
=======================================
  Hits        11188    11188           
  Misses       9719     9719           
  Partials      466      466

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

AlexFenlon
AlexFenlon approved these changes May 8, 2025
View reviewed changes
Copy link
Contributor

@AlexFenlon AlexFenlon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2025-05-08 at 12 00 38 🚀

@vepatel vepatel enabled auto-merge (squash) May 8, 2025 11:28
@vepatel vepatel merged commit a12b334 into main May 8, 2025
30 checks passed
@vepatel vepatel deleted the chore/update-oidc-refactor branch May 8, 2025 15:26
haywoodsh pushed a commit that referenced this pull request May 15, 2025
@vepatel @haywoodsh
add oidc refactor commit from ref impl (#7762)
e7ee882
@AlexFenlon AlexFenlon changed the title add oidc refactor commit from ref impl Add oidc refactor commit from ref impl Jun 23, 2025
@AlexFenlon AlexFenlon added the chore Pull requests for routine tasks label Jun 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haywoodsh haywoodsh haywoodsh approved these changes

@AlexFenlon AlexFenlon AlexFenlon approved these changes

Assignees
No one assigned
Labels
chore Pull requests for routine tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vepatel @haywoodsh @AlexFenlon