Skip to content

Remove OpenTracing Support from NIC #7633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 14, 2025
Merged

Remove OpenTracing Support from NIC #7633

merged 5 commits into from
Apr 14, 2025

Conversation

pdabelf5
Copy link
Collaborator

@pdabelf5 pdabelf5 commented Apr 11, 2025 •
edited
Loading

Proposed changes

Remove deprecated OpenTracing module

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@pdabelf5 pdabelf5 requested review from a team as code owners April 11, 2025 13:02
@github-actions github-actions bot added documentation Pull requests/issues for documentation go Pull requests that update Go code github_actions Pull requests that update Github_actions code docker Pull requests that update Docker code chore Pull requests for routine tasks labels Apr 11, 2025
@github-actions GitHub Actions
Copy link
Contributor

✅ Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/nginx-ingress-controller/7633/

@pdabelf5 pdabelf5 added the needs cherry pick Cherry pick this PR into a release branch label Apr 11, 2025
@codecov Codecov
Copy link

codecov bot commented Apr 11, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 28.57143% with 5 lines in your changes missing coverage. Please review.

Project coverage is 52.16%. Comparing base (8930bc6) to head (f6eea17).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
internal/nginx/manager.go 0.00% 3 Missing ⚠️
cmd/nginx-ingress/main.go 0.00% 1 Missing ⚠️
internal/nginx/fake_manager.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #7633      +/-   ##
==========================================
+ Coverage   52.15%   52.16%   +0.01%     
==========================================
  Files          89       89              
  Lines       21340    21269      -71     
==========================================
- Hits        11130    11096      -34     
+ Misses       9741     9709      -32     
+ Partials      469      464       -5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pdabelf5 pdabelf5 added change Pull requests that introduce a change and removed needs cherry pick Cherry pick this PR into a release branch documentation Pull requests/issues for documentation go Pull requests that update Go code github_actions Pull requests that update Github_actions code docker Pull requests that update Docker code chore Pull requests for routine tasks labels Apr 14, 2025
@pdabelf5 pdabelf5 self-assigned this Apr 14, 2025
@pdabelf5 pdabelf5 added this to the v4.1.0 milestone Apr 14, 2025
@pdabelf5 pdabelf5 mentioned this pull request Apr 14, 2025
Merged
@pdabelf5 pdabelf5 force-pushed the remove-opentracing branch from ed9aaf0 to f6eea17 Compare April 14, 2025 09:42
@github-actions github-actions bot removed the change Pull requests that introduce a change label Apr 14, 2025
@github-actions github-actions bot added documentation Pull requests/issues for documentation go Pull requests that update Go code github_actions Pull requests that update Github_actions code docker Pull requests that update Docker code chore Pull requests for routine tasks labels Apr 14, 2025
@pdabelf5 pdabelf5 enabled auto-merge (squash) April 14, 2025 10:07
@pdabelf5 pdabelf5 added change Pull requests that introduce a change and removed documentation Pull requests/issues for documentation go Pull requests that update Go code github_actions Pull requests that update Github_actions code docker Pull requests that update Docker code chore Pull requests for routine tasks labels Apr 14, 2025
@pdabelf5 pdabelf5 merged commit c3c4801 into main Apr 14, 2025
82 checks passed
@pdabelf5 pdabelf5 deleted the remove-opentracing branch April 14, 2025 10:32
@github-project-automation github-project-automation bot moved this from Todo ☑ to Done 🚀 in NGINX Ingress Controller Apr 14, 2025
haywoodsh pushed a commit that referenced this pull request May 2, 2025
@pdabelf5 @haywoodsh
Remove OpenTracing Support from NIC (#7633)
b06daa8
haywoodsh pushed a commit that referenced this pull request May 6, 2025
@pdabelf5 @haywoodsh
Remove OpenTracing Support from NIC (#7633)
b9709e3
haywoodsh pushed a commit that referenced this pull request May 15, 2025
@pdabelf5 @haywoodsh
Remove OpenTracing Support from NIC (#7633)
cf80a11
haywoodsh pushed a commit that referenced this pull request May 16, 2025
@pdabelf5 @haywoodsh
Remove OpenTracing Support from NIC (#7633)
6bef0ed
pdabelf5 added a commit that referenced this pull request May 22, 2025
@pdabelf5
Remove OpenTracing Support from NIC (#7633)
a1e6939
@chicks-net
Copy link

Why are you killing all of the otel support? Is there any migration path?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vepatel vepatel vepatel approved these changes

@AlexFenlon AlexFenlon AlexFenlon approved these changes

Assignees

@pdabelf5 pdabelf5

Labels
change Pull requests that introduce a change
Projects
NGINX Ingress Controller
Status: Done 🚀
Milestone
v5.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@pdabelf5 @chicks-net @vepatel @AlexFenlon