Skip to content

Rate limit zone sync #7468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Mar 6, 2025
Merged

Rate limit zone sync #7468

merged 18 commits into from
Mar 6, 2025

Conversation

pdabelf5
Copy link
Collaborator

@pdabelf5 pdabelf5 commented Mar 5, 2025 •
edited by AlexFenlon
Loading

Proposed changes

  • Use zone sync for rate limit policies when zone sync is enabled
  • Update existing zone sync pytests to check if plus api is showing zone sync enabled
  • Add pytest for zone sync with rate limiting, ensure zone is synced.
  • Remove pytest markers for zone sync

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@pdabelf5 pdabelf5 requested a review from a team as a code owner March 5, 2025 10:56
@github-actions github-actions bot added go Pull requests that update Go code python Pull requests that update Python code tests Pull requests that update tests labels Mar 5, 2025
@codecov Codecov
Copy link

codecov bot commented Mar 5, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 68.75000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 52.00%. Comparing base (df17906) to head (6005ef2).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
internal/k8s/controller.go 50.00% 3 Missing ⚠️
internal/configs/version2/http.go 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #7468      +/-   ##
==========================================
+ Coverage   51.77%   52.00%   +0.23%     
==========================================
  Files          89       89              
  Lines       21267    21278      +11     
==========================================
+ Hits        11011    11066      +55     
+ Misses       9815     9747      -68     
- Partials      441      465      +24

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@AlexFenlon AlexFenlon linked an issue Mar 5, 2025 that may be closed by this pull request
Set sync setting for limit_req_zone when zone_sync is enabled #7397
Closed
2 tasks
@pdabelf5 pdabelf5 marked this pull request as draft March 5, 2025 11:22
@pdabelf5 pdabelf5 marked this pull request as ready for review March 5, 2025 15:09
@haywoodsh
Copy link
Contributor

Is there validation on whether it is Plus? Also what is the default value of the zone sync boolean? Or would these be included in another PR?

vepatel
vepatel reviewed Mar 6, 2025
View reviewed changes
vepatel
vepatel reviewed Mar 6, 2025
View reviewed changes
@github-actions github-actions bot added the chore Pull requests for routine tasks label Mar 6, 2025
@AlexFenlon
Copy link
Contributor

Is there validation on whether it is Plus? Also what is the default value of the zone sync boolean? Or would these be included in another PR?

@haywoodsh

There is zone-sync itself requires Plus to be enabled in main already. ZoneSync defaults to false.

@AlexFenlon AlexFenlon enabled auto-merge (squash) March 6, 2025 10:13
@AlexFenlon AlexFenlon disabled auto-merge March 6, 2025 10:14
@AlexFenlon AlexFenlon enabled auto-merge (squash) March 6, 2025 10:56
@AlexFenlon AlexFenlon merged commit dc80468 into main Mar 6, 2025
30 checks passed
@AlexFenlon AlexFenlon deleted the rate-limit-sync branch March 6, 2025 10:58
@pdabelf5 pdabelf5 added enhancement Pull requests for new features/feature enhancements and removed go Pull requests that update Go code python Pull requests that update Python code chore Pull requests for routine tasks tests Pull requests that update tests labels Apr 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haywoodsh haywoodsh haywoodsh approved these changes

@vepatel vepatel vepatel approved these changes

@jjngx jjngx jjngx approved these changes

Assignees
No one assigned
Labels
enhancement Pull requests for new features/feature enhancements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set sync setting for limit_req_zone when zone_sync is enabled
5 participants
@pdabelf5 @haywoodsh @AlexFenlon @vepatel @jjngx