Skip to content

Update WAF v5 docs to reference WAF Compiler #7432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 28, 2025
Merged

Update WAF v5 docs to reference WAF Compiler #7432

merged 2 commits into from
Feb 28, 2025

Conversation

shaun-nx
Copy link
Contributor

Proposed changes

This change updates our WAF v5 docs go guide users to the NGINX App Protect Compiler docs.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@shaun-nx shaun-nx requested review from a team as code owners February 28, 2025 13:26
@github-actions github-actions bot added the documentation Pull requests/issues for documentation label Feb 28, 2025
@github-actions GitHub Actions
Copy link
Contributor

✅ Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/nginx-ingress-controller/7432/

@shaun-nx shaun-nx linked an issue Feb 28, 2025 that may be closed by this pull request
Update NGINX App Protect v5 documentation with reference to WAF Compiler #7399
Closed
@vepatel vepatel added the needs cherry pick Cherry pick this PR into a release branch label Feb 28, 2025
@codecov Codecov
Copy link

codecov bot commented Feb 28, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.77%. Comparing base (7e63a31) to head (72975f8).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #7432      +/-   ##
==========================================
- Coverage   53.10%   52.77%   -0.34%     
==========================================
  Files          89       89              
  Lines       21074    21267     +193     
==========================================
+ Hits        11192    11223      +31     
- Misses       9419     9580     +161     
- Partials      463      464       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shaun-nx shaun-nx enabled auto-merge (squash) February 28, 2025 14:18
@shaun-nx shaun-nx merged commit bb8b85d into main Feb 28, 2025
32 checks passed
@shaun-nx shaun-nx deleted the docs/waf-compiler branch February 28, 2025 14:21
nginx-bot pushed a commit that referenced this pull request Feb 28, 2025
@shaun-nx @vepatel @web-flow
Update WAF v5 docs to reference WAF Compiler (#7432)
422e82a 
Co-authored-by: Venktesh Shivam Patel <ve.patel@f5.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vepatel vepatel vepatel approved these changes

@AlexFenlon AlexFenlon AlexFenlon approved these changes

Assignees
No one assigned
Labels
documentation Pull requests/issues for documentation needs cherry pick Cherry pick this PR into a release branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update NGINX App Protect v5 documentation with reference to WAF Compiler
3 participants
@shaun-nx @vepatel @AlexFenlon