Skip to content

remove external golang dependencies #6712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 29, 2024
Merged

remove external golang dependencies #6712

merged 4 commits into from
Oct 29, 2024

Conversation

pdabelf5
Copy link
Collaborator

@pdabelf5 pdabelf5 commented Oct 25, 2024 •
edited
Loading

Proposed changes

  • Use http server from the go standard library. Remove external chi dependency
  • Reuse go-cmp dependency from the google/go-cmp library. Remove external kr/prettier direct dependency

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@pdabelf5 pdabelf5 requested a review from a team as a code owner October 25, 2024 11:19
@github-actions github-actions bot added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Oct 25, 2024
@codecov Codecov
Copy link

codecov bot commented Oct 25, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 25.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 53.44%. Comparing base (78a6d60) to head (8546f4b).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
internal/healthcheck/healthcheck.go 40.00% 3 Missing ⚠️
internal/metrics/listener.go 0.00% 2 Missing ⚠️
internal/certmanager/test_files/actions.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #6712   +/-   ##
=======================================
  Coverage   53.44%   53.44%           
=======================================
  Files          87       87           
  Lines       20111    20111           
=======================================
  Hits        10748    10748           
  Misses       8928     8928           
  Partials      435      435

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pdabelf5 pdabelf5 changed the title remove external chi dependency remove external golang dependencies Oct 25, 2024
@pdabelf5 pdabelf5 enabled auto-merge (squash) October 29, 2024 12:21
@pdabelf5 pdabelf5 merged commit 83d09fa into main Oct 29, 2024
81 checks passed
@pdabelf5 pdabelf5 deleted the chi-refactor branch October 29, 2024 12:57
nginx-bot pushed a commit that referenced this pull request Oct 29, 2024
@pdabelf5 @web-flow
remove external golang dependencies (#6712)
2ba7644
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexFenlon AlexFenlon AlexFenlon approved these changes

@jjngx jjngx jjngx approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file go Pull requests that update Go code
Projects
NGINX Ingress Controller
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pdabelf5 @AlexFenlon @jjngx